[YSQL] Fix flaky test TestPgRegressFeaturePartition #23094
Assignees
Labels
area/ysql
Yugabyte SQL (YSQL)
kind/enhancement
This is an enhancement of an existing feature
kind/failing-test
Tests and testing infra
priority/medium
Medium priority issue
status/awaiting-triage
Issue awaiting triage
Comments
fizaaluthra
added
area/ysql
yugabyte-ci
added
kind/failing-test
fizaaluthra
added a commit
that referenced
this issue
Jul 4, 2024
Summary: The test became flaky after commit 7c8343d fixed the logic for cascaded drops on columns. The test yb_feature_hash_types creates a domain and creates a table with a key column that has the domain as its type. However, since we currently don't support key column drops (#22902), the test fails when the cleanUpCustomEntities() function in BasePgSQLTest.java attempts to drop the domain (that has the key column as a dependant object) during cleanup. Moreover, the test is flaky because sometimes the table may be dropped before the domain, as the order of the drops depends on the pg_depend scan output, which isn't deterministic because pg_depend doesn't have a primary key and internally uses ybctid. Fix the test flakiness by dropping the table in yb_feature_hash_types before the test clean up logic. Jira: DB-12029 Test Plan: ./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressFeaturePartition' -n 20 Reviewers: myang Reviewed By: myang Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D36329
jasonyb
pushed a commit
that referenced
this issue
Jul 10, 2024
Summary: 65145f6 [PLAT-14532] Import Local Release will now try to process all releases. c5c969e [PLAT-14153] Do not count already upgraded master nodes as "inactive masters" during a software upgrade b5a2e60 [#23096] YSQL: Return empty response from pg_replication_slots instead of an error if yb_enable_replication_commands isn't true. 2d5ca88 [PLAT-14157] Implement new per process metrics in node_health.py 1607290 [PLAT-14478] Allowing prometheus auth without enabling HTTPS 57f4b33 Handling markdown space in contributors.md 9d54ca0 [docs] voyager-1.7.2 changes (#23116) b81dbaa [#23094] YSQL: Fix flaky test TestPgRegressFeaturePartition 8b202c1 [docs] Removed v2.16 (#23099) d040fd8 [PLAT-11654] Adding client level retries to Azure ybops d0917bd [PLAT-13865] Check for expiry of current in-use certs as well fbc51f6 [#23128] CDCSDK: Fix TSAN failure in TestCDCSDKConsistentStreamWithManyTransactions 44d899f [#21550] YSQL: testSetMemoryTracking UT fails with connection manager enabled 650269f [#22848] YSQL: Stats are not updated correctly for sticky connections in ysql connection manager 0fd5799 [PLAT-14527][PLAT-14538] : DB Audit log fixes and improvements 4c35006 [PLAT-12685]: Add alerts for xCluster tales based on status Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D36435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-12029
Description
Flaky after commit 7c8343d
Issue Type
kind/failing-test
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: