Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docdb] Splitting: Disable automatic splitting for tables covered by PITR schedules #8257

Closed
bmatican opened this issue May 1, 2021 · 1 comment
Closed

[docdb] Splitting: Disable automatic splitting for tables covered by PITR schedules #8257

bmatican opened this issue May 1, 2021 · 1 comment
Assignees
@spolitov @robertsami @sanketkedia
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature

Comments

@bmatican
Copy link
Contributor

bmatican commented May 1, 2021

After we have #8234, it should be very easy to expand the set of constraints on what to enable/disable splitting on.

Until we have #8235, we should just disable splitting for any tables covered by a PITR schedule.
@bmatican bmatican added the area/docdb YugabyteDB core features label May 1, 2021
@bmatican bmatican mentioned this issue May 1, 2021
Closed
@bmatican bmatican mentioned this issue May 14, 2021
Closed
@bmatican
Copy link
Contributor Author

bmatican commented Jun 8, 2021

@sanketkedia Actually this would also be a great starting point into PITR. You need a bit of context on splitting as well, but I think this de79792 from @robertsami is straightforward enough, for how to disable splitting if X.

You'll also need to know how to tell if a tablet is part of an active PITR schedule, which @spolitov introduced here 4e9665a, see the retained_by_snapshot_schedules logic.

sanketkedia added a commit that referenced this issue Jul 7, 2021
@sanketkedia
[#8257] ybase: Disable tablet splitting for PITR tracked tables
7b8babc 
Summary: Currently, we do not support PITR on split tablets, so as a short-term solution, we will disable automatic tablet splitting for them.

Test Plan: ybd --cxx_test tablet-split-itest --gtest-filter TabletSplitITest.SplittingWithPitr

Reviewers: timur, rsami, bogdan, sergei

Reviewed By: sergei

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D11941
@ttyusupov ttyusupov added the kind/enhancement This is an enhancement of an existing feature label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

@robertsami robertsami

@sanketkedia sanketkedia

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bmatican @spolitov @ttyusupov @robertsami @sanketkedia