Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix broken links in docs.yugabyte.com #11624

Closed
wants to merge 1 commit into from

Conversation

def-
Copy link
Contributor

@def- def- commented Mar 2, 2022

Found with linkchecker: https://wummel.github.io/linkchecker/

Only on latest docs, the others are not allowed based on
https://docs.yugabyte.com/robots.txt:

Sitemap: https://docs.yugabyte.com/sitemap.xml
User-agent: *
Disallow: /latest/api/ysql/syntax_resources/
Allow: /latest/api/ysql/syntax_resources/grammar_diagrams/
# don't index the non-latest docs
Disallow: /v1.3/
Disallow: /v2.0/
Disallow: /v2.1/
Disallow: /v2.2/
Disallow: /v2.4/
Disallow: /v2.6/
Disallow: /v2.8/
Disallow: /stable/

Found with linkchecker: https://wummel.github.io/linkchecker/

Only on latest docs, the others are not allowed based on
https://docs.yugabyte.com/robots.txt
@def- def- added area/documentation Documentation needed kind/bug This issue is a bug labels Mar 2, 2022
@netlify
Copy link

netlify bot commented Mar 2, 2022

✔️ Deploy Preview for infallible-bardeen-164bc9 ready!

🔨 Explore the source changes: 5f86b14

🔍 Inspect the deploy log: https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/621f5a004061480008c806e6

😎 Browse the preview: https://deploy-preview-11624--infallible-bardeen-164bc9.netlify.app

@polarweasel
Copy link
Contributor

Thank you! Will review.

Incidentally, it looks like the linkchecker version you used has been abandoned since 2016. There's an actively-maintained version at https://github.com/linkchecker/linkchecker. I'll try it out.

@polarweasel polarweasel self-requested a review March 2, 2022 16:12
@def-
Copy link
Contributor Author

def- commented Mar 2, 2022

My bad, I actually used the one you linked to, didn't realize the other website is out-of-date.

$ linkchecker --version
LinkChecker 10.1.0 released 2022-01-28
Copyright (C) 2000-2016 Bastian Kleineidam, 2010-2021 LinkChecker Authors

@polarweasel
Copy link
Contributor

I think we can close this one now that #11621 is merged. Linkchecker ran cleanly (internal links only) for me on the PR for that one.

@polarweasel polarweasel closed this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed kind/bug This issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants