Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] PR for Update kubernetes config page #11690

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

@lizayugabyte lizayugabyte self-assigned this Mar 8, 2022
@netlify
Copy link

netlify bot commented Mar 8, 2022

✔️ Deploy Preview for infallible-bardeen-164bc9 ready!

🔨 Explore the source changes: f4d5b4e

🔍 Inspect the deploy log: https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/6228d9c8b471c900088b2c85

😎 Browse the preview: https://deploy-preview-11690--infallible-bardeen-164bc9.netlify.app

@lizayugabyte lizayugabyte requested a review from ddhodge March 8, 2022 20:51
Copy link
Contributor

@ddhodge ddhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@lizayugabyte lizayugabyte merged commit 463e7d2 into yugabyte:master Mar 9, 2022
Copy link
Contributor

@yogendra yogendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recent changes in the service account setup does not work. The placeholder in the yaml files (<SA_NAMESPACE>) have to be changed to match the new placeholders (<serviceaccount_namespace>).

@lizayugabyte
Copy link
Contributor Author

Fixed the namespace error in #11917

@lizayugabyte
Copy link
Contributor Author

@yogendra The error is fixed in #11917. Could you, please, review and approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants