Defaulting Y.ButtonCore's template to type=button (#973, #968) #1296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As issue #968 mentions, any Buttons rendered without a
host
/srcNode
config option will default totype=submit
. This is the correct behavior for any<button>
element without atype
attribute (spec), however, in the context of Y.Button, that is certainly not the ideal default. It is much more likely that someone would like to listen in on a click events instead of submit the parent form. So this change updates the defaultTEMPLATE
to includetype=button
.If the intent actually is to have
type=submit
, the implementer can either override Y.ButtonCore.prototype.TEMPLATE, or specify it in a new Y.Node instance in the config (as a new test does).