fix FF contenteditable backspace bug. #1502
Conversation
|
👍 Fixes Issue for me |
ghost
assigned 
| d = e.changedNode; | ||
| t = inst.config.doc.createTextNode(' '); | ||
| d.appendChild(t); | ||
| d.removeChild(t); |
There was a problem hiding this comment.
How come this was removed? Are you assuming this problem isn't occurring anymore, or does _fixGeckoOnBackspace inadvertently fix this same problem?
There was a problem hiding this comment.
I was unable to repro this ever, so I'm assuming it's not occurring.
There was a problem hiding this comment.
All right. In that case, let's simply comment it out... just in case.
There was a problem hiding this comment.
And because I'm paranoid.
|
Thanks for submitting this fix, and sorry for the insanely late response. I've gotten this to work and it looks good. 👍 After the few minor picks above are addressed, I will proceed to merge your branch. |
|
|
||
| //will fail if onEditorReady not called within 3s | ||
| if (!editorReady) { | ||
| this.wait(3000); |
There was a problem hiding this comment.
test.wait() works by waiting for a call to test.resume(). So in this case if onEditorReady is called asynchronously your test will always fail. If something may or may not be asynchronous, I suggest you force the test to be asynchronous:
var test = this;
function onEditorReady() { ... }
setTimeout(function () {
test.makeEditorWithParaPlugin('<p> content<br></p>', function () {
test.resume(onEditorReady);
});
}, 0);
// it's best practice not to set a timeout and let the test environment decide
// which timeout to use because in CI some stuff may take longer
test.wait();
#1376