Remove src attribute in iFrame used in io-upload-iframe (Fix #1622) #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: build/loader-yui3/loader-yui3-coverage.js build/loader-yui3/loader-yui3-debug.js build/loader-yui3/loader-yui3-min.js build/loader-yui3/loader-yui3.js build/loader/loader-debug.js build/loader/loader-min.js build/loader/loader.js build/yui-nodejs/yui-nodejs-debug.js build/yui-nodejs/yui-nodejs-min.js build/yui-nodejs/yui-nodejs.js build/yui/yui-debug.js build/yui/yui-min.js build/yui/yui.js src/loader/js/yui3.js
Currently, running Calendar tests containing the focus process will fail in Firefox. The cause of this problem seems to be a problem that test case is not bad, what happens if you are running Yeti while running Firefox in the background. This problem does not occur in a browser other than Firefox. In addition, there is a test that includes a focusing process in the same way the Widget Button module [1], but it has to ignore Yeti is here. Therefore, I would like to ignore running some tests by Yeti in the same way in Calendar. Fix yui#1363. [1]: src/widget-buttons/tests/unit/assets/widget-buttons-test.js
Conflicts: src/event/js/tap.js
IO clears the form content on end, but if the caller removed the form soon after it was called, this fails at a removeAttribute on part of the, now non-existent form content. We should check that the form exists before attempting to reset it.
min files are no change.
min files are no change.
Conflicts: build/node-style/node-style-coverage.js
- Do not instrument files in Yeti. - Use ?filter=coverage query to trigger loading instrumented files in tests. Allows for `yeti -c` to use these options without specifying them on the command line.
min files are no change.
… source attribute can cause an extra request to be made to the current page URL when the iFrame is included on the page. See issue yui#1622.
|
Thanks. Before anyone freaks out, all the seemingly unrelated commits did not get merged in. Only the change in orionhealth@92f25f1 did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the problematic src attribute from the iFrame used in io-upload-iframe to enable file uploading. Fixes issue #1622.