fix EditorSelection.getCursor as it returns no elements #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue #1423 |
| try { | ||
| range.selectNode(node); | ||
| } catch (err) { | ||
| } |
There was a problem hiding this comment.
Is there a reason why this try catch was added, or was it simply for pedantry?
There was a problem hiding this comment.
This is to ignore the INVALID_NODE_TYPE_ERR being thrown in IE10/11, where this error is silently ignored in FF.
|
CLA is valid! |
| @@ -902,7 +902,11 @@ | |||
| node = Y.Node.getDOMNode(node); | |||
| var range = this.createRange(); | |||
| if (range.selectNode) { | |||
| range.selectNode(node); | |||
| // Ignore selection errors like INVALID_NODE_TYPE_ERR | |||
There was a problem hiding this comment.
can you move this comment to the catch block? it makes more sense to have it there.
since yui-cursor was changed to be a class, so the call should be changed.
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since yui-cursor was changed to be a class, so the selector should be changed