[dd] Prevent default on gesturemovestart after movement has started. #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesturemovestart is actually triggered on gesturestart/mousedown rather than on the start of movement. It then throttles down based on a mintime or min movement. We therefore need to move the preventDefault down to the function it throttles otherwise we prevent on mousedown of non-dragged object too.
|
CLA is valid! |
|
Fixes #1757 |
|
This looks like the correct fix. Verified on my end. I tested this on the IEs and it checks out:
Also, @andrewnicols has tested this on
|
|
Be sure you push this to the release branch once it's approved. |
|
Looks good. Feel free to get this into the release branch. |
|
Pushed to |
|
I updated the HISTORY.md as well with this fix. |
|
@tilomitra Here's the basic testcase I used: https://gist.github.com/10214424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gesturemovestart is actually triggered on touchstart/mousedown rather
than on the start of movement. It then throttles down based on a mintime or
min movement. We therefore need to move the preventDefault down to the
function it throttles otherwise we prevent on mousedown of non-dragged
object too.