Don't prevent-default in 'on' for document node #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _setMsTouchActions method modifies node behavior during touch events and prevents the default response from the browser. This will prevent pages from being scrolled in any direction if there is _any_ event listener set on the document node. For example in yui#1343 DDM sets an 'ongesturemove' listener on the document in order to know when to update the locations of dragged elements. BUT, the document can no longer be scrolled via touch because of the side-effect in _setTouchActions. This fixes yui#1343 and maybe yui#1795
…t to the doc element.
|
CLA is valid! |
|
@juandopazo @jacobrossi |
|
This has now been tested in ie11. |
|
Updated the |
This was referenced Sep 29, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have cherry-picked @lexander 's commit from #1865, added the following:
touchActionis available.and made the request against dev-master.