Update YUI Handlebars to use v2.0.0 #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: Gruntfile.js modified: build.json
modified: js/handlebars-base.js modified: js/handlebars-compiler-ast.js modified: js/handlebars-compiler-base.js modified: js/handlebars-compiler-compiler.js new file: js/handlebars-compiler-helpers.js modified: js/handlebars-compiler-javascript-compiler.js modified: js/handlebars-compiler-parser.js modified: js/handlebars-runtime.js modified: js/handlebars-utils.js modified: js/handlebars.js modified: js/handlebars.runtime.js
…e string `false` instead of an empty string for the value of false.
…ime. modified: Gruntfile.js
…mport a Helpers reference. modified: js/handlebars-compiler-parser.js
|
CLA is valid! |
|
I don't have too much to say about this, if it works, and tests are passing, I'm good with it. Ideally, we can get @aljimenez to try it in search manually, and see if that works. |
|
Yeah, I feel the same as Caridy. It looks like all the tests are passing, so 👍 |
|
@caridy I'll give it a try in our Search apps. Thank you all, we look forward to using the latest handlebars features. |
|
I updated the |
|
I've tested these changes on our Search application with Mojito and everything works as expected so far. |
|
\o/ |
This was referenced Sep 29, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds some updates to #1908 for including handlebars v2.0.0.
This is pull request is dependent on yui/handlebars.js#2 as the updated handlebars code causes an error in the YUI Template test suite.