Setup Y.config.global only if no user global was provided

[juandopazo]

The goal behind this change is to allow for YUI to work on CSP regulated sites and environments like Chrome extensions by providing the global in the user configuration. Setting Y.config.global in the user configuration doesn't trigger the use of Function to get to the global object.

No idea how to test the side-effects of this change.

/cc @caridy @tripp

[yahoocla]

CLA is valid!

[caridy]

💯

[okuryu]

This still gets warning CSP, is this just as you expected?

Why not following? Was I wrong?

diff --git a/src/yui/js/yui.js b/src/yui/js/yui.js
index c93f011..580b33f 100644
--- a/src/yui/js/yui.js
+++ b/src/yui/js/yui.js
@@ -153,7 +153,7 @@ available.
         return Y;
     };

-(function() {
+(function(global) {

     var proto, prop,
         VERSION = '@VERSION@',
@@ -477,7 +477,7 @@ proto = {
             useBrowserConsole: true,
             useNativeES5: true,
             win: win,
-            global: Function('return this')()
+            global: global
         };

         //Register the CSS stamp element
@@ -1639,7 +1639,7 @@ Y.log('Fetching loader: ' + config.base + config.loaderPath, 'info', 'yui');
     }

     YUI.Env[VERSION] = {};
-}());
+}(this));

[caridy]

yeah, this PR is not attempting to fix it, but to provide a way to workaround it. basically, you can now do: YUI({ global: window }) and the CSP warning will go away.

[tripp]

Cherry-picked into dev-master.

[okuryu]

yeah, this PR is not attempting to fix it, but to provide a way to workaround it. basically, you can now do: YUI({ global: window }) and the CSP warning will go away.

Ah, gotcha. Thanks explaining.

[okuryu]

Updated the HISTORY.md in 578344f.

[juandopazo]

@okuryu thanks!