-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rest parameters syntax for multiple params #158
Conversation
It doesn't work in my PC though. Maybe a Windows vs Linux thing. |
I'm ok with a "no". I just wanted to discuss it with working code. |
Looks good to me. Do not need to leave to document the old format? |
I'd like to merge this. I just confirmed that the conflicts were resolved and passed tests on my box. /cc @caridy |
LGTM. Does this maintain BC? It looks like it does. Then I'm good with it. |
Yup, the user guide will suggests new syntax, but the parser maintains backward compatibility. |
\o/ |
I'm planning the next release v0.4.0, so this feature will be includes into that. |
CLA is valid! |
77ed3cf
to
7a1647c
Compare
@okuryu I resolved the conflicts! |
@juandopazo Nice! I just merged, thanks! |
Hi!
Rest parameter syntax is coming in EcmaScript 6 (already in Firefox Nightly!). It looks like this:
I think it makes sense to use this syntax instead of YUIDoc's
*
for multiple parameters. It's easier to remember (I sometimes confuse it withType[]
) and maybe some day we'll be using it in real code. This pull request updates the docs to use...params
, and adds the option for@param {Type} ...params
and@param {Type} [...params].
I added tests for this feature but I can't seem to run them from the command line. Is there anything else I should do besides running
node tests\parser.js
?