Skip to content

Commit

Permalink
[core] Merge pull request rspec/rspec-core#2884 from rspec/update-min…
Browse files Browse the repository at this point in the history
…imum-rr-version

Remove support for older RR test double framework versions

---
This commit was imported from rspec/rspec-core@e0a4407.
  • Loading branch information
pirj authored Apr 7, 2021
2 parents bd58fe8 + 9d3d09d commit f504c51
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
1 change: 1 addition & 0 deletions rspec-core/Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Breaking Changes:
* Raise on attempt to use a legacy formatter without `rspec-legacy_formatters`.
(Phil Pirozhkov, #2864)
* Unify multi-condition filtering to use "all" semantic. (Phil Pirozhkov, #2874)
* Remove support for RR test double framework version < 3.0. (Phil Pirozhkov, #2884)

Enhancements:

Expand Down
2 changes: 1 addition & 1 deletion rspec-core/lib/rspec/core/mocking_adapters/rr.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def self.framework_name
:rr
end

include ::RR::Extensions::InstanceMethods
include ::RR::DSL

def setup_mocks_for_rspec
::RR::Space.instance.reset
Expand Down
2 changes: 1 addition & 1 deletion rspec-core/rspec-core.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Gem::Specification.new do |s|
s.add_development_dependency "coderay", "~> 1.1.1"

s.add_development_dependency "mocha", "~> 0.13.0"
s.add_development_dependency "rr", "~> 1.0.4"
s.add_development_dependency "rr", "~> 3.0.0"
s.add_development_dependency "flexmock", "~> 0.9.0"
s.add_development_dependency "thread_order", "~> 1.1.0"

Expand Down
4 changes: 1 addition & 3 deletions rspec-core/spec/support/fake_libs/rr.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ module Errors
BACKTRACE_IDENTIFIER = /doesn't matter/
end

module Extensions
module InstanceMethods
end
module DSL
end
end

0 comments on commit f504c51

Please sign in to comment.