-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monthly downloads badge to README #537
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 91.34% 91.04% -0.31%
==========================================
Files 13 13
Lines 1919 1931 +12
Branches 402 431 +29
==========================================
+ Hits 1753 1758 +5
- Misses 110 117 +7
Partials 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@yukinarit IMHO you should revert this change. This person tried to open this exact PR against a project I'm the maintainer for as well (ixmatus/inflector#16). This is a promotional campaign and they (or colleagues) appear to be doing it on reddit too, I think this is suspicious activity. They are creating an external dependency on a web property that (as far as I can tell) is not officially blessed by pypi. I recommend reverting this PR. Users can get package statistics from |
Thanks @ixmatus @Aman-Clement Any objections? otherwise I am reverting this change. |
@yukinarit I appreciate you're giving this person the benefit of the doubt and an opportunity to object but I thought you should know that I just went through quite a few python repository PRs where this person and their colleague shot gunned this exact change. It's either an attempt at promotion and SEO link juicing (the more innocent interpretation), or a more nefarious attempt at establishing first-time contributor trust (because they will now have "Contributor" label by their name on your repository for any PRs they open) so they can make malicious changes later. |
Thank you for your feedback and concerns. I'd like to clarify that this is not a promotional campaign. As stated in the PR description, our intention is simply to share a tool we have developed, which we believe could be beneficial to the community. Our badge system offers highly accurate statistics, which is why we wanted to make it available. If the link to the pip trends page is a concern, we are more than willing to remove it. We respect your decision if you prefer not to add more badges to your README. Our primary goal is to address any misunderstandings and assure you that this is a genuine effort to contribute to the open-source community by sharing our work on GitHub. Thank you for considering our contribution. |
Added a monthly downloads badge by pip Trends to the README which updated daily.
View more at - https://piptrends.com/widgets/pyserde