Сustom bucket endpoint url #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugorodgerbrown
requested changes
Oct 28, 2021
There was a problem hiding this comment.
@kidig thanks for the PR - the change seems like a good one in principal. I have highlighted one are where I think there is a gap. Could you add some tests for this case (test get_file_url function with a setting that includes both region and bucket placeholders), and ensure that it won't fail.
add some tests
|
@hugorodgerbrown I moved it to a function and added some tests. |
hugorodgerbrown
approved these changes
Oct 30, 2021
|
Thanks @kidig - I've run the tests, and they look good, and have merged your PR. I'll publish an update in due course (you can pin to master in the meantime). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
There a few S3-like services, who also use standard boto3 package.
For example, the Object Storage at Yandex.Cloud (https://cloud.yandex.com/en-ru/services/storage).
I've just add an optional setting
S3UPLOAD_BUCKET_ENDPOINT. It's enough for third-party storages!"That's one small change for the library. One giant leap for the django!" 😉