Support ScatteredExecutor #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scatter-local-executor is enabled by default when using Embulk >0.8, which runs mulitple instance of OrcTransactionalPageOutput in parallel. This ends up calling orc.impl.MemoryManagerImpl, which is *not* multi-thread safe. This change introduces WriterLocalMemoryManager, which is a simple thread-safe implementation of orc.MemoryManager bound to each orc.Writer instance. With this change, embulk-output-orc can be safely used from Embulk >0.8.
|
Just noticed the CI failing on the style check. I'll update shortly. |
|
Excellent! Something that I should have done myself a long time ago. Thanks. |
yuokada
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #16