-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement changes due to Article DTO changes #17
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for realworld-fsd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Dodje sorry for the dalay. I made some changes with favorite/unfavorite model. You can check that out. As you mentioned, requests do not return up-to-date data in the case of an optimistic update, but cached data, we need to make changes to ignore the cache in certain cases, after that the main tasks will be done and the next goal is review and MR |
I'm also sorry for delays, it just happens to coincide with vacation, but I'm trying to be online :)
What would you suggest here? I'm not familiar with ReactQuery. But It seems like we are going to fix backend bug on frontend, which is not good at all.. Sadly backend is not working again, getting 500 Some update: So we have What do you think? |
As starting point here are some changes which were mentioned in the comment:
#16 (comment)
And