Allow missing and null pointer fields to be nil. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures missing fields for pointer field types remain nil:
* This allows one to distinguish the field wasn't present from the
field being NULL when the PtrNil option is false.
* This also makes it more convenient to reuse structs with pointer
field types with various encoders like the standard library JSON
marshaler, where you may want to omit a field if it didn't exist in
the queried results.
The expectations around this change are captured in the
TestMissingFields test.
In addition, it also fixes an edge case where even with PtrNil set to
true, pointer field types would always return with a pointer to a zero
value instead of being nil even when the query property's value is
VT_NULL.
This fix is checked by the TestNullPointerField test.
yusufpapurcu
approved these changes
May 18, 2023
|
Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures missing fields for pointer field types remain nil:
The expectations around this change are captured in the TestMissingFields test.
In addition, it also fixes an edge case where even with PtrNil set to true, pointer field types would always return with a pointer to a zero value instead of being nil even when the query property's value is VT_NULL.
This fix is checked by the TestNullPointerField test.
These changes provide a bit more flexibility when utilizing custom queries with classes that may have different fields on different versions of Windows.