Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

add Dockerfile and adjust readme to reflect a quick start #19

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

kniec
Copy link

@kniec kniec commented Jun 29, 2020

Took the freedom to add a Dockerfile and adjusting the readme to have a quick start (#11).

@yuvipanda
Copy link
Owner

Thank you for working on this, @kniec!

We currently rely on the 'apt.txt' and 'environment.yml' to do the same thing you're doing in the Dockerfile - those work on mybinder.org with repo2docker. In general I prefer that, especially over inheriting from a heavy docker image like datascience-notebook.

We could add this as an example of 'if you want to build your own Dockerfile from jupyter-stacks' or build a 'minimal Dockerfile' version. What do you think?

@kniec
Copy link
Author

kniec commented Jun 30, 2020

I changed the base image to a smaller (220MB) version of the jupyter notebook.

What would be the minimal version of the notebook you would see possible?

@yuvipanda yuvipanda merged commit 9c7403c into yuvipanda:master Jul 7, 2020
@yuvipanda
Copy link
Owner

This is more useful than what we have now, so <3 thanks @kniec! Apologies for the delayed merge.

yuvipanda pushed a commit that referenced this pull request Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants