Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate support library dependencies to androidx #254

Merged
merged 1 commit into from
May 26, 2019

Conversation

damien5314
Copy link
Contributor

@damien5314 damien5314 commented May 19, 2019

Why this change is needed?

AndroidX is replacing the Android support library. Client applications for CardStackView can currently use the library by enabling jetifier within Android Studio, but long term it's probably best to update to AndroidX at the source.

What has changed in this PR?

  • Simply ran the AndroidX migration tool in Android Studio. All android.support packages have been replaced with the new androidx dependencies.
  • Enables jetifier in gradle options to allow the sample app to compile. This is required because Glide is not yet AndroidX compatible.

How to test it?

  • Smoke test sample app

@yuyakaido
Copy link
Owner

@damien5314 Thanks!

@yuyakaido yuyakaido merged commit cefc6d8 into yuyakaido:master May 26, 2019
@yuyakaido
Copy link
Owner

@damien5314
Ver. 2.3.3 has been released including this improvement.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants