Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when key exists in others #14

Closed
syrte opened this issue Nov 24, 2019 · 1 comment
Closed

Bug when key exists in others #14

syrte opened this issue Nov 24, 2019 · 1 comment
Assignees

Comments

@syrte
Copy link
Contributor

syrte commented Nov 24, 2019

adstex/adstex.py

Lines 394 to 398 in 5723da4

if (key_exists and args.update) or (
key_exists_in_others and args.merge_other and args.update
):
bibcode = extract_bibcode(bib.entries_dict[key])
bibcode_new = entry2bibcode(bib.entries_dict[key])

When key_exists_in_others is True and key_exists is False, the procedure will crash at bibcode = extract_bibcode(bib.entries_dict[key]), because bib.entries_dict does not have key there.

yymao added a commit that referenced this issue Nov 24, 2019
@yymao yymao self-assigned this Nov 24, 2019
yymao added a commit that referenced this issue Nov 24, 2019
@yymao
Copy link
Owner

yymao commented Nov 24, 2019

Thanks for the bug report! Fixed by #15.

@yymao yymao closed this as completed Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants