Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line breaks in citations cause failed capturing of bib keys #22

Closed
birnstiel opened this issue Mar 10, 2020 · 2 comments · Fixed by #23
Closed

Line breaks in citations cause failed capturing of bib keys #22

birnstiel opened this issue Mar 10, 2020 · 2 comments · Fixed by #23
Assignees
@yymao
Labels
accepted

Comments

@birnstiel
Copy link
Contributor

natbib citations such as

\citep[see also][]{Aauthor2019,Bauthor2020}

are not correctly recognized if a line-break occurs. Some authors/text editors might hard-wrap this citation at the space:

Lorem ipsum dolor sit amet, consectetur adipiscing \citep[see
also][]{Aauthor2019,Bauthor2020} eget risus sollicitudin neque
imperdiet suscipit.

adstex fails to detect those bib keys.
@birnstiel birnstiel changed the title Line breaks in citations not correctly capture all citations Line breaks in citations cause failed capturing of bib keys Mar 10, 2020
@yymao yymao self-assigned this Mar 10, 2020
@yymao yymao added the accepted label Mar 10, 2020
@yymao yymao mentioned this issue Mar 10, 2020
Merged
@yymao
Copy link
Owner

yymao commented Mar 10, 2020

@birnstiel Thanks for reporting the issue. I have made an attempt to fix this issue in #23. If you can test the pull request that'd be great. I'll also test it and, if things go well, make a release later today.

@birnstiel
Copy link
Contributor Author

wow that was fast! it works for my case.

@yymao yymao closed this as completed in #23 Mar 16, 2020
yymao added a commit that referenced this issue Mar 16, 2020
@yymao
Merge pull request #23 from /issues/22/allow-line-breaks
dea8a98 
Allow line breaks in citation commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yymao yymao

Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow line breaks in citation commands yymao/adstex
2 participants
@yymao @birnstiel