include co-authors in search query #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'll take a closer look and run some tests when I get time. |
|
Thank you @birnstiel for the suggestion. I think this is a good idea, but I'd also like to preserve the original behavior as well because some people may use I'll merge your PR into the yymao:u/yymao/v0.6 branch and work on it further. |
|
This PR has been incorporated in v0.6.0. Let me know if you encounter any issues @birnstiel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the format
Firstauthor:secondauthor:yearstill only searches for thefirstauthorandyear. I modified the regular expression to include the entire colon-separated part and then split this into coauthors that are added to the queue if they exist. I tested this in a couple of cases and it seems to work and not break something, but please test yourself – hope I didn't break something.