Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Weblate working again #1559

Closed
lucasmz-dev opened this issue Sep 5, 2024 · 23 comments · Fixed by #1557
Closed

Getting Weblate working again #1559

lucasmz-dev opened this issue Sep 5, 2024 · 23 comments · Fixed by #1557
Labels
enhancement New feature or request

Comments

@lucasmz-dev
Copy link
Contributor

lucasmz-dev commented Sep 5, 2024

This is meant to track my work getting the project @ Weblate to work reliably.

@lucasmz-dev lucasmz-dev added the enhancement New feature or request label Sep 5, 2024
@lucasmz-dev
Copy link
Contributor Author

#1558 so that Weblate does not believe these strings to be translated properly when they're not

@lucasmz-dev
Copy link
Contributor Author

Preferably asking the project at Toolate to be removed to decrease issues

@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Sep 5, 2024

Merge all translation related PRs, and also #1557 to point users to Weblate

That should be it so that I can unlock the project with care

Adding https://hosted.weblate.org/engage/innertune/ afterwards if this all works out as a translation link in F-Droid could be nice

@lucasmz-dev lucasmz-dev changed the title Getting Weblate working Getting Weblate working agaom Sep 5, 2024
@lucasmz-dev lucasmz-dev changed the title Getting Weblate working agaom Getting Weblate working again Sep 5, 2024
@z-huang
Copy link
Owner

z-huang commented Sep 5, 2024

@lucasmz-dev Many thanks to your contribution! In the past, I tried to set up Weblate but failed. Now, more people can contribute translations in a more friendly platform!

Adding hosted.weblate.org/engage/innertune afterwards if this all works out as a translation link in F-Droid could be nice

How to do it?

@lucasmz-dev
Copy link
Contributor Author

I'm actually not sure 😬
I was looking into it and I couldn't find the metadata files in F-Droid for InnerTune for some reason

@lucasmz-dev
Copy link
Contributor Author

@lucasmz-dev
Copy link
Contributor Author

Do you think it'd make sense to highlight Weblate working in the next update in changelogs? Like add a line saying "Our Weblate is now working! Check out the translation link in F-Droid to help us translate the app to more languages!"

@z-huang
Copy link
Owner

z-huang commented Sep 9, 2024

Yeah, it's okay.

@lucasmz-dev
Copy link
Contributor Author

@z-huang
image

Should I change it to GPL-3.0-or-later? I'm unsure here of how the licensing works

@Anonuser-code
Copy link
Contributor

@lucasmz-dev Many thanks to your contribution! In the past, I tried to set up Weblate but failed. Now, more people can contribute translations in a more friendly platform!

Adding hosted.weblate.org/engage/innertune afterwards if this all works out as a translation link in F-Droid could be nice

How to do it?

Which platform do you use for translation of app? I want to help about it.

@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Sep 12, 2024

@Anonuser-code

Weblate, the same link you mentioned

Thanks for the help :)

@Anonuser-code
Copy link
Contributor

@Anonuser-code

Weblate, the same link you mentioned

Thanks for the help :)

Then i did my translation on this site before. And when Zion going to update the languages?

@lucasmz-dev
Copy link
Contributor Author

@Anonuser-code no promises. I would guess if everything goes alright then whenever next updates comes.

If you'd like to check out how the translations are looking like, you can check the Weblate pull request and download the APK from GitHub actions by checking the "uploading APK" section.

@lucasmz-dev
Copy link
Contributor Author

#1592 has some revelant info

@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Sep 13, 2024

Should I change it to GPL-3.0-or-later? I'm unsure here of how the licensing works

On this, I originally did, then put it back, and now I put it back on GPL-3.0-or-later, this licensing is specific to the translations, I think translations should be permissive, translators can't always be contacted and it would be a pain to do so already

@maboroshin
Copy link
Contributor

maboroshin commented Dec 2, 2024

Please check what is currently PL'd. (PL is pull request) If uploaded directly to GitHub, string.xml is PLed. https://github.com/z-huang/InnerTune/pulls?q=is%3Apr+is%3Aclosed

History

@lucasmz-dev
Copy link
Contributor Author

Sorry @maboroshin I'm lost, what are trying to say? What does PL mean?

@lucasmz-dev
Copy link
Contributor Author

I actually just now really became aware of the Crowdin. I was searching through issues and was like "huh?"

I could see if I could get these translations inside Weblate, in case no one already messed with them anyway

@maboroshin
Copy link
Contributor

Thank you for your efforts.There was some confusion due to lack of announcements. I have documented it.

At present, developers should stop Crowdin. But that has not been done so there will be people doing translations on Crowdin. Documentation is needed for those confused.

@lucasmz-dev
Copy link
Contributor Author

@z-huang maybe close Crowdin? Not sure if that's complicated

If there's any translations that haven't been merged and it's easy like Weblate to get a git history for it I would, I could look into if it makes any sense to put them in, though at this point they might have been overwritten by other people anyway

@lucasmz-dev
Copy link
Contributor Author

Traffic there is pretty minimal at least a few strings every now and then but very much dead

@z-huang
Copy link
Owner

z-huang commented Dec 2, 2024

maybe close Crowdin? Not sure if that's complicated

Closed.

@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Dec 13, 2024

I have set up screenshots in Weblate, should help random translators that don't have the app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants