-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable linter checks which cause issues with Weblate formatting #1592
Conversation
Seems like what weblate is doing is:
Two things stand out though:
Other than those two issues it seems fine. |
I also noticed some of the translation files contained ignore flags for linting from the mentioned issues, these were not removed by Weblate; not sure if we should; probably not There was one instance that was from ImpliedQuantity, really the one string that caused a warning, seems like it was because it was on only that specific string and Weblate wrote over it. |
I am not sure if this is the right thing to do, that's more on z-huang to decide. It seems it was being done, just on a smaller scale specific to translation, this doesn't seem to be easily possible with Weblate or at least would be an annoying regular job |
This is not for all strings, just a few, that for some reason, Weblate just ignores them. This issue doesn't seem to exist in Android, just there. |
I went over and fixed these manually in Weblate. (The French strings) Now the only issue left is Belarusian, |
89f875d
to
8ddc145
Compare
Disables MissingQuantity and ImpliedQuantity.
8ddc145
to
f3e38df
Compare
Disables MissingQuantity and ImpliedQuantity.
Fixes #1591