Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable linter checks which cause issues with Weblate formatting #1592

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

lucasmz-dev
Copy link
Contributor

@lucasmz-dev lucasmz-dev commented Sep 13, 2024

Disables MissingQuantity and ImpliedQuantity.

Fixes #1591

@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Sep 13, 2024

TODO: Review https://github.com/lucasmz-dev/CONTRIB-InnerTune/pull/1/files?diff=unified&w=0 to check what Weblate is doing when rewriting all translations to try and match a format

Seems like what weblate is doing is:

  • Getting rid of empty lines (not necessarily good but whatever, it makes comparing files with the base file more annoying)
  • Getting rid of duplicate plurals which are gonna be used anyway (example)
  • Formatting some multi-line strings (example)

Two things stand out though:

  • For Belarusian, it believes other should be the same as many, while the original strings were translated to use the same as few. (example)
  • For French, it gets rid of apostrophes, not sure if the format was just wrong in the first place or what happened (example)

Other than those two issues it seems fine.
I tried looking for the Belarusian translator but he seems to have gone EOL.

@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Sep 13, 2024

I also noticed some of the translation files contained ignore flags for linting from the mentioned issues, these were not removed by Weblate; not sure if we should; probably not

There was one instance that was from ImpliedQuantity, really the one string that caused a warning, seems like it was because it was on only that specific string and Weblate wrote over it.

@lucasmz-dev lucasmz-dev changed the title Disable linter checks which cause issues with Weblate Disable linter checks which cause issues with Weblate formatting Sep 13, 2024
@lucasmz-dev
Copy link
Contributor Author

I am not sure if this is the right thing to do, that's more on z-huang to decide. It seems it was being done, just on a smaller scale specific to translation, this doesn't seem to be easily possible with Weblate or at least would be an annoying regular job

@lucasmz-dev lucasmz-dev marked this pull request as ready for review September 13, 2024 22:54
@lucasmz-dev
Copy link
Contributor Author

For French, it gets rid of apostrophes, not sure if the format was just wrong in the first place or what happened (example)

This is not for all strings, just a few, that for some reason, Weblate just ignores them. This issue doesn't seem to exist in Android, just there.
https://translate.codeberg.org/translate/innertune_testing/app/fr/?checksum=8aaaf36a36a9c864&q=dattente&sort_by=-priority%2Cposition#history

@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Sep 13, 2024

I went over and fixed these manually in Weblate. (The French strings)
It actually seems like they were using the wrong symbol for the apostrophes, ` instead of '

Now the only issue left is Belarusian, I think I'm gonna just mark plurals as need for editing and move on.

Disables MissingQuantity and ImpliedQuantity.
@z-huang z-huang merged commit bfca361 into z-huang:dev Oct 27, 2024
2 checks passed
@lucasmz-dev lucasmz-dev deleted the lint-weblate-fix branch October 28, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter complains about missing plurals when Weblate does translation cleanup
2 participants