-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop silencing useful information. #258
Conversation
The thrown errors didn't hold any useful information and made debugging impossible. Before: Error: Could not parse jison grammar After: Error: Parse error on line 86: ... ;expatom = atom '^' nat --------------------^ Expecting ':', got 'ID'
👍 This would have been very helpful to me in the past. |
+1 |
Do we have any idea why the code was changed in the first place? Presumably there was a good reason to put the try/catches in there. |
👍 This fix works great on 0.4.15. Went from a generic "could not parse" to specific info on the syntax error. Thanks! It should be merged. |
+1 |
It is better to rethrow exceptions than silence them. This way code shows that there is an exception that might need a handler. techtonik@db44303 |
+1 |
👍 I just hacked the changed into my local copy of JISON, and suddenly I get useful error messages. |
Seems like exception silencing got introduced with commit ea11654. The commit message doesn't mention this:
|
Any reason why this hasn't been merged in two years? |
Because @zaach is missing? |
+1 |
@zaach This is an essential fix for anyone developing a complex grammar. Please merge! |
Abandoned project with useless error messages... |
Yep sadly... Better switch to the Typescript front-end of Antlr
https://github.com/tunnelvisionlabs/antlr4ts/blob/master/README.md
…On Thu, Jul 26, 2018, 23:26 John Burns Arundo ***@***.***> wrote:
Abandoned project with useless error messages...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#258 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC2D-VdJsjBBdSDh5WjnyiQmYqwyIklbks5uKjP9gaJpZM4C2hNr>
.
|
The thrown errors didn't hold any useful information and made debugging
impossible.
Before:
After: