feat: add support for three-way-comparison (spaceship) operator

Close GH-52
zackad · Aug 26, 2024 · e5e9c54 · e5e9c54
1 parent b754eb6
commit e5e9c54
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## unreleased
 
+### Features
+- Add support for three-way-comparion operator (spaceship operator)
+
 ### Bugfixes
 - Fix handling mapping that omit key part
 - Fix documentation about `twigAlwaysBreakObjects` option to reflect actual default value

diff --git a/src/melody/melody-extension-core/operators.js b/src/melody/melody-extension-core/operators.js
@@ -124,6 +124,12 @@ export const BinaryGreaterThanOrEqualExpression = createBinaryOperatorNode({
     precedence: 20,
     associativity: LEFT
 });
+export const BinaryThreeWayComparisonExpression = createBinaryOperatorNode({
+    text: "<=>",
+    type: "BinaryThreeWayComparisonExpression",
+    precedence: 20,
+    associativity: LEFT
+});
 
 export const BinaryNotInExpression = createBinaryOperatorNode({
     text: "not in",

diff --git a/tests/Expressions/__snapshots__/arrowFunctions.snap.twig b/tests/Expressions/__snapshots__/arrowFunctions.snap.twig
@@ -6,3 +6,6 @@ Arrow function with multiple arguments:
 
 Arrow function with multiple arguments and second filter argument:
 {{ numbers|reduce((carry, v, k) => carry + v * k, 10) }}
+
+Arrow function with three-way-comparison (spaceship) operator
+{{ array|sort((a, b) => a.value <=> b.value) }}
diff --git a/tests/Expressions/__snapshots__/operators.snap.twig b/tests/Expressions/__snapshots__/operators.snap.twig
@@ -26,6 +26,7 @@
 {{ a ? b }}
 {{ a ? : b }}
 {{ a ?? b }}
+{{ a <=> b }}
 
 {{ a is divisible by(b) }}
 {{ a is not divisible by(b) }}

diff --git a/tests/Expressions/arrowFunctions.twig b/tests/Expressions/arrowFunctions.twig
@@ -6,3 +6,6 @@ Arrow function with multiple arguments:
 
 Arrow function with multiple arguments and second filter argument:
 {{ numbers|reduce((carry, v, k) => carry + v * k, 10) }}
+
+Arrow function with three-way-comparison (spaceship) operator
+{{ array|sort((a, b) => a.value <=> b.value) }}
diff --git a/tests/Expressions/operators.twig b/tests/Expressions/operators.twig
@@ -26,6 +26,7 @@
 {{ a ? b }}
 {{ a ?: b }}
 {{ a ?? b }}
+{{ a <=> b }}
 
 {{ a is divisible by(b) }}
 {{ a is not divisible by(b) }}