Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life improvements #31

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Quality of life improvements #31

merged 4 commits into from
Jul 18, 2024

Conversation

rellafella
Copy link
Collaborator

  • add logos
  • update readme
  • Add some js doc types where appropriate
    • this can require a bit of refactoring in places
    • just started for now in index.js
  • Format flake file using nixfmt

@rellafella rellafella requested a review from zackad July 17, 2024 03:06
@zackad
Copy link
Owner

zackad commented Jul 17, 2024

You add lots of logo, but I don't see they being used other than wide-*.svg variant. Is this really necessary?

@rellafella
Copy link
Collaborator Author

This is most definitely a "rather have them and not need them, than need them and not have them approach" I can assure you that you do not want to be re-making these logos as it is a pretty painstaking process.
I have used the prettier-logo repo as a basis for this decision making.
Is it necessary, absolutely not. Is it nice to have to add some polish to areas as this plugin evolves, I would think so.

Copy link
Owner

@zackad zackad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@zackad zackad merged commit 790d1d5 into zackad:master Jul 18, 2024
2 checks passed
@rellafella rellafella deleted the master branch July 18, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants