Skip to content

Commit

Permalink
fix uploading binary data through ETAPI, closes #2667
Browse files Browse the repository at this point in the history
  • Loading branch information
zadam committed Feb 18, 2022
1 parent d940590 commit 9f33791
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ app.use(helmet({

app.use(express.text({limit: '500mb'}));
app.use(express.json({limit: '500mb'}));
app.use(express.raw({limit: '500mb'}));
app.use(express.urlencoded({extended: false}));
app.use(cookieParser());
app.use(express.static(path.join(__dirname, 'public')));
Expand Down
25 changes: 25 additions & 0 deletions test-etapi/put-note-content-binary.http
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
POST {{triliumHost}}/etapi/create-note
Authorization: {{authToken}}
Content-Type: application/json

{
"parentNoteId": "root",
"title": "Hello",
"type": "image",
"mime": "image/png",
"content": ""
}

> {% client.global.set("createdNoteId", response.body.note.noteId); %}

###

PUT {{triliumHost}}/etapi/notes/{{createdNoteId}}/content
Authorization: {{authToken}}
Content-Type: application/octet-stream
Content-Transfer-Encoding: binary

< ../images/icon-color.png

> {% client.assert(response.status === 204); %}

2 changes: 2 additions & 0 deletions test-etapi/put-note-content.http
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ Content-Type: text/plain

Changed content

> {% client.assert(response.status === 200); %}

###

GET {{triliumHost}}/etapi/notes/{{createdNoteId}}/content
Expand Down

0 comments on commit 9f33791

Please sign in to comment.