Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) . For help visit wiki. #2546

Closed
Myzel394 opened this issue Jan 13, 2022 · 9 comments
Closed

(Bug report) . For help visit wiki. #2546

Myzel394 opened this issue Jan 13, 2022 · 9 comments

Comments

@Myzel394
Copy link
Contributor

Myzel394 commented Jan 13, 2022

Trilium Version

0.49.4

What operating system are you using?

Ubuntu

What is your setup?

Server access only

Operating System Version

Linux myzel394-computer 5.15.0-2-amd64 #1 SMP Debian 5.15.5-2 (2021-12-18) x86_64 GNU/Linux

Description

Trying out the new sharing functionality. However, I only get to see this message:

`
image

There are no errors in the browser console and all requests succeed with 200.

@zadam
Copy link
Owner

zadam commented Jan 13, 2022

Hi, is it reproducible?

Are you using the released 0.49.4 or perhaps master branch?

@Myzel394
Copy link
Contributor Author

I'm using 0.49.4 (from DockerHub)

@zadam
Copy link
Owner

zadam commented Jan 13, 2022

Hmm, unfortunately I can't reproduce that on a demo document on the docker image.

There were some bugs regarding search which could influence this, but there would be errors in the console. But just to rule this out, does this still happen if you restart the application (also backend) and look into this immediately (without doing anything else)?

@Myzel394
Copy link
Contributor Author

Unfortunately that didn't work :/

No errors in backend either, however, this line seems a bit strange, doesn't it?
image

btw, I get a lot of these warnings in the browser, but I don't think it is related to this issue:

image

@zadam
Copy link
Owner

zadam commented Jan 13, 2022

The BBBB is just a left-over debug message.

The clone-to-note is fine, except that it's a bit slow.

If you'd be willing to create an anonymized database and send it to me at zadam.apps@gmail.com, I might be able to reproduce the issue ...

@Myzel394
Copy link
Contributor Author

Okay I sent you a link to the database, please check your mails

@zadam
Copy link
Owner

zadam commented Jan 14, 2022

Thank you. Unfortunately sharing seems to work fine on the anonymized database.

I'm at a loss what could be the issue.

I noticed that there is some custom widget (of course anonymized) - it's a long shot, but could it interfere here? Might be worth disabling it.

@Myzel394
Copy link
Contributor Author

Myzel394 commented Jan 14, 2022

Okay I found the problem:

The <span /> element IS actually present, however it has the style display: none !important in Firefox only. So I can see the span in Chrome and access the shared link both in Chrome and Firefox. I also think the problem is not in Firefox itself but in a extension that's inserting stylesheets (I think it's uBlock Origin, because it's a selector with like 1000 elements).

EDIT

Okay I found the problem! So apparently my adblocker thinks that all elements with the class "share-text" are for sharing to social media. Maybe we could change the class name?

Here's (part of) the stylesheet:

image

EDIT 2

Yep, can confirm this works. I changed the class name and now it works.

@zadam
Copy link
Owner

zadam commented Jan 14, 2022

Wow, that's nasty!

Anyway, I changed the classes, hopefully these aren't in the list.

@zadam zadam closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants