Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Reopen last tab doesn't work #3397

Closed
Nriver opened this issue Dec 8, 2022 · 4 comments
Closed

(Bug report) Reopen last tab doesn't work #3397

Nriver opened this issue Dec 8, 2022 · 4 comments
Milestone

Comments

@Nriver
Copy link
Contributor

Nriver commented Dec 8, 2022

Trilium Version

0.57.3

What operating system are you using?

Other Linux

What is your setup?

Local + server sync

Operating System Version

Manjaro

Description

reopenLastTab does not work.
Press Ctrl+Shift+T, the console shows error message:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'ntxId')
    at C.reopenLastTabCommand (tab_manager.js:497)
    at C.callMethod (component.js:97)
    at A.triggerCommand (app_context.js:92)
    at keyboard_actions.js:42
    at HTMLDocument.<anonymous> (utils.js:144)
    at HTMLDocument.handleObj.handler (jquery.hotkeys.js:183)
    at HTMLDocument.dispatch (jquery.min.js:2)
    at HTMLDocument.v.handle (jquery.min.js:2)
@zadam
Copy link
Owner

zadam commented Dec 8, 2022

Hi, thanks for the report. Is it reproducible? Unfortunately all my attempts work.

@Nriver
Copy link
Contributor Author

Nriver commented Dec 9, 2022

Yes, it's reproducible. I tested it with a fresh database.

demo

@zadam
Copy link
Owner

zadam commented Dec 9, 2022

Thanks, can reproduce now - this happends when you close the last existing tab which has a special behavior. This isn't completely trivial to tackle, so will probably happen in the next feature release.

@zadam zadam added this to the backlog milestone Dec 9, 2022
@zadam
Copy link
Owner

zadam commented Dec 14, 2022

fix in next58 branch

@zadam zadam closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants