Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Hidden notes appear in search results #3516

Open
contributor opened this issue Jan 12, 2023 · 3 comments
Open

(Bug report) Hidden notes appear in search results #3516

contributor opened this issue Jan 12, 2023 · 3 comments

Comments

@contributor
Copy link
Contributor

contributor commented Jan 12, 2023

Trilium Version

0.58.4

What operating system are you using?

Windows

What is your setup?

Local (no sync)

Operating System Version

Windows 10 Pro 19044.2364

Description

This is fresh default database created by 0.58.4

image

Error logs

No response

@contributor
Copy link
Contributor Author

contributor commented Jan 12, 2023

The same for Open a Note
image

@contributor contributor changed the title (Bug report) Hidden notes appears in search results (Bug report) Hidden notes appear in search results Jan 12, 2023
@zadam
Copy link
Owner

zadam commented Jan 13, 2023

Hello, I agree that the global search should not display hidden notes (unless hoisted into the hidden subtree) and that has been fixed.

But regarding the autocomplete - I think it can be useful for e.g. linking hidden notes - being able to e.g. link to Options notes or in the future to Help notes. Hidden notes are currently penalized in the results and appear only after non-hidden notes.

@contributor
Copy link
Contributor Author

contributor commented Jan 26, 2023

Version 0.58.7
I have a note A with sub-notes under root. Added this note to launch bar bookmarks (so it has an icon on left bar)
Now, I want to move another note B from Inbox to A. I press Ctrl+Shift+X while I'm on B, then type name of the note A in the "Move notes too.." dialog. I see only suggestions for hidden tree paths, and not for actual (original path).

So suggested notes are:
Hidden Notes/Launch Bar/Visible Launchers/Bookmarks/A/***
instead of
root/A/***

Often, there is no way to move B to A (even if I would accept hard to read hidden path), because it only displays three subnotes Hidden Notes/Launch Bar/Visible Launchers/Bookmarks/A/***, but not Hidden Notes/Launch Bar/Visible Launchers/Bookmarks/A itself (my target root). Sometime, A and its three subnotes are suggested, but sometime - only subnotes.

Regardless, ``Hidden Notes/Launch Bar/...` path should not be suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants