Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Attachment Links not working as expected #4562

Open
Br0kenSilos opened this issue Jan 5, 2024 · 1 comment
Open

(Bug report) Attachment Links not working as expected #4562

Br0kenSilos opened this issue Jan 5, 2024 · 1 comment

Comments

@Br0kenSilos
Copy link

Trilium Version

0.62.4

What operating system are you using?

Windows

What is your setup?

Local + server sync

Operating System Version

Windows 10 Pro 22H2 (OS Build 19045.3803)

Description

Desktop = Windows 10 Pro
Server = Ubuntu Server 22.04 / Docker container
Browser 1 = Firefox 121.0 (Does not work)
Browser 2 = Microsoft Edge 120.0.2210.91 (Does work)

This maybe related to or a duplicate of issue #4388 but hopefully provides additional details if a duplicate. When trying to copy a link to attachments within a note, the copy link command seems to work on the Windows desktop client. But it does not work in the web client (accessed via Firefox). Additionally, if the link is created in the desktop client it works properly, but the same link does not always work within the web client.

In this example, i pre-set my clipboard to be abc123.. The files were attached using the web client.
image
After clicking copy link to clipboard, my clipboard is unchanged and is still abc123

However, if I switch over to the desktop client and try to copy the link to the clipboard I get this. It seems to work
image

Then I go into the note and try to paste the link into some text
image

If I then click the link (still in the desktop client), it takes me to the attachments list.
image

In this case, the link seems to work in the web client. But I have seen instances where it did not.

Error logs

None to provide. If specific error logs are needed, please let me know where to retrieve them.

@zadam
Copy link
Owner

zadam commented Jan 7, 2024

Hello, this actually looks like it is working as intended:

 

image

This doesn't copy the URL to the clipboard, it contains the link itself. You just paste it into the text content.

In this case, the link seems to work in the web client. But I have seen instances where it did not.

This sounds like #4509 which should be fixed in the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants