Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) if the image link in the attachment is used to display the image in the note (paste the link). An error will occur #4509

Closed
flysaber opened this issue Dec 8, 2023 · 2 comments

Comments

@flysaber
Copy link

flysaber commented Dec 8, 2023

Trilium Version

v0.62.4

What operating system are you using?

Windows

What is your setup?

Local + server sync

Operating System Version

Windows 10,Ubuntu 22.04

Description

If you choose to upload images in the attachment and then paste the image link in the attachment to your notes. After synchronization, either your server cannot display images, or your local end cannot display images.
Specifically, if you create notes locally, the server will not be able to display images after synchronization.
If you create notes on the server side, the image cannot be displayed on the local side after synchronization.

Error logs

none

@flysaber flysaber changed the title (Bug report) paste the image link in the attachment to your notes. An error will occur (Bug report) if the image link in the attachment is used to display the image in the note (paste the link). An error will occur Dec 8, 2023
@flysaber flysaber changed the title (Bug report) if the image link in the attachment is used to display the image in the note (paste the link). An error will occur (Bug report) if the image link in the attachment is used to display the image in the note (paste the link). An error will occur Dec 8, 2023
@Nriver
Copy link
Contributor

Nriver commented Dec 15, 2023

I can replicate the issue you mentioned.

The link generated by the Copy link to clipboard on the attachments page includes the domain information. If it originates from the client, it starts with 'http://127.0.0.1/', causing the server web to be unable to display it. Conversely, if it is generated from the server, it starts with 'https://your_domain'.

Left is client, and right is the server. They can not see the image created by each other.
ksnip_20231215-150521

@zadam
Copy link
Owner

zadam commented Dec 27, 2023

Hello, thank you for reporting this issue, will be fixed in the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants