Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Canvas image cannot be loaded (404) in shared note when note title contains '/' #4578

Closed
deajan opened this issue Jan 9, 2024 · 1 comment

Comments

@deajan
Copy link
Contributor

deajan commented Jan 9, 2024

Trilium Version

0.62.5

What operating system are you using?

Other Linux

What is your setup?

Local + server sync

Operating System Version

Almalinux 9.3

Description

Some of my canvas notes didn't show up properly in a shared note, so I investigated, and found that / character isn't escaped in the URL tofetch the canvas image. Same applies to \ character, and probably others.

Notename containing /

image

Shared image cannot be loaded (404) in browser:

image

Sane note name

image

Produces sane shared output

image

Error logs

Navigator inspection log when note is called test note from 09/01/2024

GET https://notes.local/share/api/images/zf1jTwY0N1kL/test%20note%20from%2009/01/2024?2024-01-09%2013:52:17.925Z 404
@zadam
Copy link
Owner

zadam commented Jan 9, 2024

Hello, thank you for reporting this bug, fixed.

@zadam zadam closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants