Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Excalidraw Upgrade v0.11-v0.12 #2994

Merged
merged 3 commits into from
Jul 17, 2022
Merged

Conversation

thfrei
Copy link
Contributor

@thfrei thfrei commented Jul 17, 2022

What: Upgrade of excalidraw from v0.11-v0.12

Main features:

  • Eraser
  • Double pinch while drawing?

Main fixes in regard to trilium:

  • Render SVG free path backgrounds
  • Should fix an issue with electron svg/image export?!

Problems:

  • At the beginning I had the issue, that somehow canvas-notes were not longer of type canvas, but instead of type file. Does anyone else have this? When upgrading?

Next steps:

  • I will do some more testing, would be glad if someone can also test.
  • In the next couple of days, remove wip state.

@thfrei thfrei changed the title wip: Excalidraw Upgrade v011-v012 wip: Excalidraw Upgrade v0.11-v0.12 Jul 17, 2022
@Nriver
Copy link
Contributor

Nriver commented Jul 17, 2022

Yes, there is one time my canvas note become a json file.

To recover, I create a new canvas note and export, then replace the json and reimport to get my canvas note back.

Do not know how to reproduce it.

@thfrei
Copy link
Contributor Author

thfrei commented Jul 17, 2022

I think it might actually have to do something with the sql migrations or something? maybe it is an "undfined" note type and there gets transformed?

Also: Is it a bug or a feature, that one cannot change the type for files?!

@thfrei
Copy link
Contributor Author

thfrei commented Jul 17, 2022

Also, one can change it during runtime with SQL Console:

update notes set `type` = 'canvas' where noteId = 'xyz'

However, it seems that trilium server instance needs to be reloaded.

@zadam
Copy link
Owner

zadam commented Jul 17, 2022

@thfrei trilium sets note to "file" type if the type is not recognized. This could happen if you e.g. have server still running an older version of Trilium before canvas has been released. Or perhaps you ran the older version once on desktop by mistake. Something like that.

@zadam zadam merged commit 82d7179 into zadam:master Jul 17, 2022
@zadam
Copy link
Owner

zadam commented Jul 17, 2022

Thanks!

@thfrei thfrei deleted the excalidraw-v012 branch July 17, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants