Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polaris restart fw #36

Closed
wants to merge 42 commits into from
Closed

Conversation

rayhe88
Copy link

@rayhe88 rayhe88 commented Oct 12, 2023

I have updated the way we map tasks on each node for ALCF machines. Each task runs on a different FWorker, and each FWorker is associated with a node. This is available for multilauncher. The optimal approach is to set num_jobs to the number of nodes.

Additionally, I have added functionality to use PWDFT, including the calculator and related functions.

@sakim8048
Copy link
Contributor

will add self.machine in main.py:
when machine="alcf" then it will follow alcf restart mode.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Attention: 431 lines in your changes are missing coverage. Please review.

Comparison is base (ed98fc2) 51.97% compared to head (f731ba7) 46.60%.

Files Patch % Lines
pynta/ase_pwdft/pwdftio/pwdftwriter.py 10.62% 185 Missing ⚠️
pynta/multi_launcher.py 18.00% 82 Missing ⚠️
pynta/main.py 31.25% 55 Missing ⚠️
pynta/ase_pwdft/pwdftio/pwdftreader.py 18.42% 31 Missing ⚠️
pynta/utils.py 15.62% 27 Missing ⚠️
pynta/polaris.py 18.51% 22 Missing ⚠️
pynta/ase_pwdft/pwdft.py 60.71% 11 Missing ⚠️
pynta/tasks.py 65.62% 11 Missing ⚠️
pynta/ase_pwdft/setup.py 0.00% 5 Missing ⚠️
pynta/ase_pwdft/pwdftio/pwdftreader_in.py 83.33% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   51.97%   46.60%   -5.38%     
==========================================
  Files          12       21       +9     
  Lines        3032     3566     +534     
==========================================
+ Hits         1576     1662      +86     
- Misses       1456     1904     +448     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjohnson541 mjohnson541 closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants