feat: allow to customize the blocked labels #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoan Blanc <yoan.blanc@chuv.ch>
Signed-off-by: Yoan Blanc <yoan.blanc@chuv.ch>
Open
harmathy
reviewed
Nov 12, 2024
Signed-off-by: Yoan Blanc <yoan.blanc@chuv.ch>
Signed-off-by: Yoan Blanc <yoan.blanc@chuv.ch>
harmathy
approved these changes
Nov 15, 2024
Signed-off-by: Yoan Blanc <yoan.blanc@chuv.ch>
% ct lint --target-branch master
Linting charts...
------------------------------------------------------------------------------------------------------------------------
Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
cluster-secret => (version: "0.5.0", path: "charts/cluster-secret")
------------------------------------------------------------------------------------------------------------------------
Linting chart "cluster-secret => (version: \"0.5.0\", path: \"charts/cluster-secret\")"
Checking chart "cluster-secret => (version: \"0.5.0\", path: \"charts/cluster-secret\")" for a version bump...
Old chart version: 0.4.4
New chart version: 0.5.0
Chart version ok.
Validating /Users/yo6568/soft/ClusterSecret/charts/cluster-secret/Chart.yaml...
Validation success! 👍
Validating maintainers...
==> Linting charts/cluster-secret
1 chart(s) linted, 0 chart(s) failed
------------------------------------------------------------------------------------------------------------------------
✔︎ cluster-secret => (version: "0.5.0", path: "charts/cluster-secret")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully
% python3 conformance/tests.py
Checking pod cluster-secret-clustersecret-c6c8b8698-5pbm5...
Event: Successfully assigned cluster-secret/cluster-secret-clustersecret-c6c8b8698-5pbm5 to colima
Event: Container image "cluster-secret:foo" already present on machine
Event: Created container clustersecret
Event: Started container clustersecret
Pod cluster-secret-clustersecret-c6c8b8698-5pbm5 is ready!
Namespace 'example-1' created successfully.
Namespace 'example-2' created successfully.
Namespace 'example-3' created successfully.
~/ClusterSecret/venv/lib/python3.13/site-packages/kubernetes/client/rest.py:44: DeprecationWarning: HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. Instead access HTTPResponse.headers directly.
return self.urllib3_response.getheaders()
.........
----------------------------------------------------------------------
Ran 9 tests in 55.681s
OK |
Signed-off-by: Yoan Blanc <yoan.blanc@chuv.ch>
|
@harmathy LGTY ? Should we merge?, did you tested this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #150.
In short, recent ArgoCD Helm charts are not using app.kubernetes.io/instance but something else, which can be changed. This opens the door to tweaking the values via the chart.