Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code formatting in README #95

Merged

Conversation

yuppie-flu
Copy link
Contributor

This PR mainly fixes code formatting in README examples by consistently using spaces instead of tab and spaces mix.
The PR also improve the documentation a bit:

  • recommend to use maven wrapper
  • fixing the configuration example by providing an array of properties

}
]
}
[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this listing was always meant as just as an excerpt of a whole file, hence omitting the brackets. I strongly agree with the change though, it has always been confusing 😄

@lukasniemeier-zalando
Copy link
Collaborator

👍

@lukasniemeier-zalando lukasniemeier-zalando merged commit 9274783 into zalando-incubator:main Jan 3, 2024
4 checks passed
@yuppie-flu yuppie-flu deleted the impove-readme branch January 3, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants