This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Hot-fix the cluster-scoped resource discovery in namespaced operators #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pykube-ng
did a discovery of the resources and cached them in memory, so it knew which resources are namespaced, which are cluster-scoped — and generated the URLs accordingly.When switched to
aiohttp
, this discovery logic was lost, so all URLs became either cluster-scoped (by default) or namespaced (if the operator had--namespace
defined).The only thing broken is the cluster-scoped resources in the namespaced operators: they could not be reached (404 Not Found), because they do not exist in the namespaces.
This is a hot-fix for 0.23. No unit-tests — to be added later. Tested manually in presumably all combinations in Minikube — now, it works as it was before 0.23.
Types of Changes