Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Hot-fix the cluster-scoped resource discovery in namespaced operators #250

Merged

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Nov 20, 2019

Issue : #249
Broken in #227

Description

pykube-ng did a discovery of the resources and cached them in memory, so it knew which resources are namespaced, which are cluster-scoped — and generated the URLs accordingly.

When switched to aiohttp, this discovery logic was lost, so all URLs became either cluster-scoped (by default) or namespaced (if the operator had --namespace defined).

The only thing broken is the cluster-scoped resources in the namespaced operators: they could not be reached (404 Not Found), because they do not exist in the namespaces.

This is a hot-fix for 0.23. No unit-tests — to be added later. Tested manually in presumably all combinations in Minikube — now, it works as it was before 0.23.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

@nolar nolar added the bug Something isn't working label Nov 20, 2019
@zincr
Copy link

zincr bot commented Nov 20, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Nov 20, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar requested review from dneuhaeuser-zalando and removed request for samurang87 November 20, 2019 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants