Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Add few missing kwargs to the handler invocation (used in docs) #80

Merged
merged 1 commit into from
May 28, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented May 27, 2019

Issue : #79

Add the missing kwargs to the handler functions for the commonly used metadata fields. Specifically, namespace was mentioned in the docs, but absent in the code.

@nolar nolar added the bug Something isn't working label May 27, 2019
@nolar nolar added this to the 1.0 milestone May 27, 2019
@nolar nolar requested a review from samurang87 as a code owner May 27, 2019 21:07
@zincr
Copy link

zincr bot commented May 27, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented May 27, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar merged commit ff34f5f into zalando-incubator:master May 28, 2019
@nolar nolar deleted the 79-absent-handler-kwargs branch May 28, 2019 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants