ingress/routesrv: Makes skipper_routesrv_enabled a three state switch #4940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| {{ if ne .ConfigItems.skipper_routesrv_enabled "true" }} | |||
| {{ if ne .ConfigItems.skipper_routesrv_enabled "false" }} | |||
There was a problem hiding this comment.
Fixes a wrong condition introduced by #4937
| # skipper_routesrv_enabled is a three state switch: | ||
| # - "false" - routesrv deployment is removed, skipper uses own k8s dataclient | ||
| # - "pre" - routesrv is deployed, skipper uses own k8s dataclient | ||
| # - "exec" - routesrv is deployed, skipper uses routesrv |
There was a problem hiding this comment.
Used exec instead of true similar to nlb_switch and to hint that its a three state config
There was a problem hiding this comment.
no that's not needed here. skipper-ingress waits for first successful route load and routesrv has the time to startup before it hurts skipper-ingress.
Merged
mikkeloscar
reviewed
Jan 27, 2022
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
routesrv-three-state-config
branch
from
eddb7f8
to
d4f18a1
Compare
|
👍 |
1 similar comment
|
👍 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Yastrebov alexander.yastrebov@zalando.de