Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and ease zmon s3 buckets #5099

Merged
merged 2 commits into from
Apr 1, 2022
Merged

fix and ease zmon s3 buckets #5099

merged 2 commits into from
Apr 1, 2022

Conversation

vetinari
Copy link
Collaborator

@vetinari vetinari commented Apr 1, 2022

  • fix missing {{}}
  • just require the bucket name, this still allows for bucket_name or bucket_name/sub-folder access

@vetinari
fix and ease zmon s3 buckets
e37ade8 
* fix missing {{}}
* just require the bucket name, this still allows for `bucket_name` or `bucket_name/sub-folder` access
@vetinari
, must be last arg
169704c
@mikkeloscar
Copy link
Contributor

👍

1 similar comment
@gargravarr
Copy link
Contributor

👍

@gargravarr gargravarr merged commit ddd246a into dev Apr 1, 2022
@gargravarr gargravarr deleted the fix-and-ease-s3 branch April 1, 2022 09:50
This was referenced Apr 1, 2022
Merged
Merged
@zalando-teapot-robot zalando-teapot-robot mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged/alpha merged/beta merged/stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vetinari @mikkeloscar @gargravarr @zalando-teapot-robot