Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kube-node-ready optional #8426

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Make kube-node-ready optional #8426

merged 1 commit into from
Oct 22, 2024

Conversation

mikkeloscar
Copy link
Contributor

@mikkeloscar mikkeloscar commented Oct 22, 2024

kube-node-ready has lost its usefulness for several reasons:

  • Karpenter nodes don't run it which is the majority of nodes in most clusters
  • kube-node-ready was introduced at a time where we had a problem that ASGs could be automatically AZ reblanced, terminating nodes before the replacements had a chance to startup. Having nodes only marked ready in the ASG once the kube-node-ready pod was running slowed this rebalancing down. We no longer have AZ rebalance enabled, so not relevant.
  • We used it as a pseudo way to check pod network functionality, but we now have kubenurse which does a better job at this.

This PR introduces a config-item kube_node_ready_enabled which lets us disable it. The intention is to first disable in test clusters and later in all clusters.

This is indirectly motivated by switching to IMDSv2 for which kube-node-ready is not compatible with.

@mikkeloscar mikkeloscar added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Oct 22, 2024
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
@mikkeloscar mikkeloscar force-pushed the kube-node-ready-optional branch from 8fd1571 to 03d3dce Compare October 22, 2024 10:01
@mikkeloscar
Copy link
Contributor Author

👍

1 similar comment
@demonCoder95
Copy link
Member

👍

@mikkeloscar mikkeloscar merged commit f42ab86 into dev Oct 22, 2024
10 checks passed
@mikkeloscar mikkeloscar deleted the kube-node-ready-optional branch October 22, 2024 11:52
This was referenced Oct 22, 2024
@k8s-on-aws-manager-app k8s-on-aws-manager-app bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/alpha merged/beta merged/stable minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants