Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues/1821 retrieve content-type from Ktor's OutgoingContent #1833

Merged
merged 3 commits into from
May 14, 2024
Merged

issues/1821 retrieve content-type from Ktor's OutgoingContent #1833

merged 3 commits into from
May 14, 2024

Conversation

kasmarian
Copy link
Member

Description

Adding a logic to Ktor's ClientRequest class to retrieve Content-Type from OutgoingContent object, if it's not present in the request headers.

Motivation and Context

addresses #1821

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@kasmarian kasmarian mentioned this pull request May 13, 2024
Closed
@ChristianLohmann
Copy link
Member

👍

@kasmarian kasmarian merged commit b708ea0 into main May 14, 2024
2 checks passed
@kasmarian kasmarian deleted the issues/1821-content-type-header-client branch May 14, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra whiskeysierra is a code owner

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando lukasniemeier-zalando is a code owner

@msdousti msdousti Awaiting requested review from msdousti msdousti is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasmarian @ChristianLohmann