Skip to content

Commit

Permalink
Apply suggestions from code review (#769)
Browse files Browse the repository at this point in the history
Co-authored-by: Paŭlo Ebermann <paul.ebermann@zalando.de>
  • Loading branch information
Tronje Krop and ePaul authored Jul 20, 2023
1 parent 3de5648 commit 9690f26
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion chapters/performance.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ unencoded content for testing. This is ensured by content negotiation using the
{Accept-Encoding} request header (see {RFC-9110}#section-12.5.3[RFC 9110
Section 12.5.3]). Successful compression is signaled via the {Content-Encoding}
response header (see {RFC-9110}#section-8.4[RFC 9110 Section 8.4]). Clients and
servers may support other compression algorithms as `compress`, `deflate`, or
servers may support other compression formats as `compress`, `deflate`, or
`br`.

To signal server support for compression the API specification should define
Expand Down
22 changes: 11 additions & 11 deletions models/headers-1.0.0.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ Accept-Encoding:
Supported compression algorithms of the server are [**gzip**][gzip] and
**identity**, but other encodings from list below may be support too:
* **gzip** - a compression format that uses [Lempel-Ziv coding][gzip]
(LZ77) with a 32-bit CRC.
* **compress** - a format using the [Lempel-Ziv-Welch][lzw] (LZW)
algorithm.
* **gzip** - a[compression format with the [gzip file format][gzip]
(including a 32 bit CRC) around the [deflate][deflate] compression algorithm.
* **deflate** - A compression format that uses the [zlib][zlib] structure
with the [deflate][deflate] compression algorithm.
* **compress** - a format using the [Lempel-Ziv-Welch][lzw] (LZW)
algorithm.
* **br** - a compression format that uses the [Brotli][brotli] algorithm.
* **identity** - the identity function without modification or compression
used to indicate unchanged responses. This value is always considered as
Expand All @@ -38,7 +38,7 @@ Accept-Encoding:
[rfc-9110-12.5.3]: <https://tools.ietf.org/html/rfc9110#section-12.5.3>
[api-156]: <https://opensource.zalando.com/restful-api-guidelines/#156>
[gzip]: <https://en.wikipedia.org/wiki/LZ77_and_LZ78#LZ77>
[gzip]: <https://en.wikipedia.org/wiki/gzip>
[lzw]: <https://en.wikipedia.org/wiki/LZW>
[zlib]: <https://en.wikipedia.org/wiki/Zlib>
[deflate]: <https://en.wikipedia.org/wiki/DEFLATE>
Expand Down Expand Up @@ -183,15 +183,15 @@ Content-Encoding:
the recipient to decode the content in order to obtain the original payload
format.
Supported compression algorithms of the server are [**gzip**][gzip] and
Always supported compression algorithms of the server are [**gzip**][gzip] and
**identity**, but other encoding from list below may be support too:
* **gzip** - a compression format that uses [Lempel-Ziv coding][gzip]
(LZ77) with a 32-bit CRC.
* **compress** - a format using the [Lempel-Ziv-Welch][lzw] (LZW)
algorithm.
* **gzip** - a[compression format with the [gzip file format][gzip]
(including a 32 bit CRC) around the [deflate][deflate] compression algorithm.
* **deflate** - A compression format that uses the [zlib][zlib] structure
with the [deflate][deflate] compression algorithm.
* **compress** - a format using the [Lempel-Ziv-Welch][lzw] (LZW)
algorithm.
* **br** - a compression format that uses the [Brotli][brotli] algorithm.
* **identity** - the identity function without modification or compression
used to indicate unchanged responses. This value is always considered as
Expand All @@ -208,7 +208,7 @@ Content-Encoding:
[rfc-9110-8.4]: <https://tools.ietf.org/html/rfc9110#section-8.4>
[api-156]: <https://opensource.zalando.com/restful-api-guidelines/#156>
[gzip]: <https://en.wikipedia.org/wiki/LZ77_and_LZ78#LZ77>
[gzip]: <https://en.wikipedia.org/wiki/gzip>
[lzw]: <https://en.wikipedia.org/wiki/LZW>
[zlib]: <https://en.wikipedia.org/wiki/Zlib>
[deflate]: <https://en.wikipedia.org/wiki/DEFLATE>
Expand Down

0 comments on commit 9690f26

Please sign in to comment.