Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarity on x-extensible-enum usage for events #807

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Conversation

tfrauenstein
Copy link
Member

No description provided.

chapters/compatibility.adoc Outdated Show resolved Hide resolved
@a1exsh
Copy link
Member

a1exsh commented Apr 29, 2024

When I think about it, the x-extensible-enum gives a stronger signal to the event publishers: namely, the set of currently accepted values.

For the event consumers, in turn, it only signifies the list of currently most commonly found values, but does not restrict the future or the past set of possible values in any way. In that regard it's not much different from a free-form string with examples provided.

Co-authored-by: a1exsh <a1exsh@users.noreply.github.com>
@a1exsh
Copy link
Member

a1exsh commented Apr 29, 2024

👍

1 similar comment
@tkrop
Copy link
Member

tkrop commented May 28, 2024

👍

@ePaul
Copy link
Member

ePaul commented Jun 11, 2024

@tfrauenstein wanted to extend the PR as discussed in the Meeting (internal link)

@tfrauenstein
Copy link
Member Author

done

chapters/compatibility.adoc Outdated Show resolved Hide resolved
chapters/compatibility.adoc Outdated Show resolved Hide resolved
chapters/compatibility.adoc Outdated Show resolved Hide resolved
chapters/compatibility.adoc Outdated Show resolved Hide resolved
tfrauenstein and others added 2 commits June 27, 2024 18:05
Co-authored-by: Tronje Krop <tronje.krop@zalando.de>
Co-authored-by: Tronje Krop <tronje.krop@zalando.de>
@tfrauenstein
Copy link
Member Author

👍

1 similar comment
@tkrop
Copy link
Member

tkrop commented Jun 27, 2024

👍

@tkrop tkrop merged commit 8158217 into main Jun 27, 2024
2 checks passed
@tkrop tkrop deleted the tfrauenstein-patch-2 branch June 27, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants