Update changelog with rule changes since 2021 #816
Conversation
invalid team IDThe team ID in your You can follow this guideline for help. |
| @@ -39,7 +39,7 @@ check-rules-duplicates: | |||
| fi; | |||
|
|
|||
| check-rules-incorrects: | |||
| @INCORRECT="$$(grep -rnE "(\[[0-9]+\]|\[ +#?[0-9]+ +\])" $(DIRCONTENTS))"; \ | |||
| @INCORRECT="$$(grep -rnE "(\[[0-9]{1,4}\]|\[ +#?[0-9]+ +\])" $(DIRCONTENTS))"; \ | |||
There was a problem hiding this comment.
The number-only commit references were tripping up this check. I made it only validate rules that are 1-4 digits, e.g. [123] and [12] but not [815821].
There was a problem hiding this comment.
A small restriction we should remember in a few years. Would 5 be also acceptable for the problem you like to solve?
There was a problem hiding this comment.
4 digit rules are still ok, if we get to 5 digits I'll buy you lunch ;)
|
👍 |
|
@SmilyOrg didn't you also want to push a script on how this can be reproduced? |
I will try to clean that up and add it. Meanwhile check out the GHE gist for the first iteration (internal link) |
|
👍 |
Quality of the changelog to be validated :)
(For #782)