filters/auth/grant: support client id and secret file placeholders #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
filters/auth/grant-client-id-template
branch
from
7af06c6 to
eeb6839
Compare
This change enables `{host}` placeholder in the client id and secret filenames.
E.g. for the request to `foo.example.org` when flag values are `-oauth2-client-id-file=/var/run/secrets/{host}-client-id` and
`-oauth2-client-secret-file=/var/run/secrets/{host}-client-secret`
the client id and secret files would be `/var/run/secrets/foo.example.org-client-id` and
`/var/run/secrets/foo.example.org-client-secret` respectively.
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
filters/auth/grant-client-id-template
branch
from
eeb6839 to
d201006
Compare
szuecs
reviewed
Mar 6, 2023
| if err == nil { | ||
| rt.t.Logf("\n%v", rt.responseString(resp)) | ||
| } else { | ||
| rt.t.Logf("response err: %v", err) |
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Mar 4, 2024
Followup on #2246 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables
{host}placeholder in the client id and secret filenames.E.g. for the request to
foo.example.orgwhen flag values are-oauth2-client-id-file=/var/run/secrets/{host}-client-idand-oauth2-client-secret-file=/var/run/secrets/{host}-client-secretthe client id and secret files would be/var/run/secrets/foo.example.org-client-idand/var/run/secrets/foo.example.org-client-secretrespectively.